chore: regenerate models from upstream schemas #60

Merged

stack72 merged 1 commit from automated/regenerate-models into main 2026-06-19 01:16:12 +00:00

Conversation 1 Commits 1 Files changed 40 +2975 -94

stack72 commented 2026-06-18 06:09:41 +00:00

Owner

Copy link

Summary

Automated regeneration of extension models from upstream provider schemas.

Schema Sources

• AWS: CloudFormation Resource Schema
• GCP: Google Discovery Documents
• Hetzner: Hetzner Cloud OpenAPI spec
• DigitalOcean: DigitalOcean OpenAPI spec

Review Notes

• Files under model/ are auto-generated — review the manifest.yaml diffs for version changes
• CalVer versioning with content-based change detection ensures versions only bump when content changes
• Publishing happens automatically when this PR is merged (via the publish workflow)

## Summary Automated regeneration of extension models from upstream provider schemas. ### Schema Sources - **AWS**: CloudFormation Resource Schema - **GCP**: Google Discovery Documents - **Hetzner**: Hetzner Cloud OpenAPI spec - **DigitalOcean**: DigitalOcean OpenAPI spec ### Review Notes - Files under `model/` are auto-generated — review the `manifest.yaml` diffs for version changes - CalVer versioning with content-based change detection ensures versions only bump when content changes - Publishing happens automatically when this PR is merged (via the publish workflow)

stack72 added 1 commit 2026-06-18 06:09:41 +00:00

chore: regenerate models from upstream schemas (2026-06-18) 996be18c31

stack72 commented 2026-06-18 06:23:13 +00:00

Author

Owner

Copy link

Code Review

Blocking Issues

1. Model files contain substantive content changes with no corresponding codegen/ changes.

   All 40 changed files are under model/. The changes go well beyond version/upgrade entries — they include new Zod schemas, new fields added to existing schemas, and entirely new model files (e.g., model/gcp/aiplatform/extensions/models/onlineevaluators.ts). Per CLAUDE.md and the review criteria, model files may only change without codegen/ changes in two cases: (a) pure version bumps via the bump-versions script, or (b) a codegen regeneration that also modifies codegen/. Neither applies here.

   Specific examples of non-trivial content changes:

   • model/aws/s3/extensions/models/bucket.ts: New AnnotationTableConfigurationSchema added with multiple fields.
   • model/aws/bedrockagentcore/extensions/models/configuration_bundle.ts: New KmsKeyArn field with regex validation added to GlobalArgsSchema, StateSchema, and InputsSchema.
   • model/aws/wafv2/extensions/models/web_acl.ts: New PriceSchema, PaymentNetworkSchema, CryptoConfigSchema, and MonetizationConfig added.
   • model/gcp/aiplatform/extensions/models/onlineevaluators.ts: Entirely new 1208-line file.

   Context: The commit message ("chore: regenerate models from upstream schemas") matches the pattern of prior regeneration PRs (#55, #59). The generated code structure is consistent with the codegen pipeline's output style. This strongly suggests the codegen tool was run against updated upstream schemas, and the pipeline code itself was unchanged — a common workflow not explicitly covered by the two documented legitimate cases. However, per the stated review criteria, this must be flagged as a blocking issue because codegen/ was not modified.

   Resolution: Either (a) confirm that deno task generate:aws and deno task generate:gcp were actually run to produce these changes (and document that "regeneration without pipeline changes" is a legitimate third case), or (b) if the changes were hand-edited, revert and regenerate via the codegen pipeline instead.

Suggestions

None.

## Code Review ### Blocking Issues 1. **Model files contain substantive content changes with no corresponding `codegen/` changes.** All 40 changed files are under `model/`. The changes go well beyond version/upgrade entries — they include new Zod schemas, new fields added to existing schemas, and entirely new model files (e.g., `model/gcp/aiplatform/extensions/models/onlineevaluators.ts`). Per CLAUDE.md and the review criteria, model files may only change without `codegen/` changes in two cases: (a) pure version bumps via the `bump-versions` script, or (b) a codegen regeneration that also modifies `codegen/`. Neither applies here. **Specific examples of non-trivial content changes:** - `model/aws/s3/extensions/models/bucket.ts`: New `AnnotationTableConfigurationSchema` added with multiple fields. - `model/aws/bedrockagentcore/extensions/models/configuration_bundle.ts`: New `KmsKeyArn` field with regex validation added to `GlobalArgsSchema`, `StateSchema`, and `InputsSchema`. - `model/aws/wafv2/extensions/models/web_acl.ts`: New `PriceSchema`, `PaymentNetworkSchema`, `CryptoConfigSchema`, and `MonetizationConfig` added. - `model/gcp/aiplatform/extensions/models/onlineevaluators.ts`: Entirely new 1208-line file. **Context:** The commit message ("chore: regenerate models from upstream schemas") matches the pattern of prior regeneration PRs (#55, #59). The generated code structure is consistent with the codegen pipeline's output style. This strongly suggests the codegen tool was run against updated upstream schemas, and the pipeline code itself was unchanged — a common workflow not explicitly covered by the two documented legitimate cases. However, per the stated review criteria, this must be flagged as a blocking issue because `codegen/` was not modified. **Resolution:** Either (a) confirm that `deno task generate:aws` and `deno task generate:gcp` were actually run to produce these changes (and document that "regeneration without pipeline changes" is a legitimate third case), or (b) if the changes were hand-edited, revert and regenerate via the codegen pipeline instead. ### Suggestions None.

stack72 merged commit aeb7369fd7 into main 2026-06-19 01:16:12 +00:00

stack72 deleted branch automated/regenerate-models 2026-06-19 01:16:12 +00:00

stack72 referenced this pull request from a commit 2026-06-19 01:16:14 +00:00

chore: regenerate models from upstream schemas (#60)

stack72 referenced this pull request 2026-06-23 23:10:00 +00:00

chore: regenerate AWS models from upstream schemas #62

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

swamp-club/swamp-extensions!60

No description provided.