fix(gatorwalk-factory): swamp-club-swamp-extensions stages read current inputs (swamp-club #2873) #411

Merged

seth merged 1 commit from cue/2873-gatorwalk-factory-swamp into main

2026-10-01 15:19:57 +00:00

seth commented

2026-10-01 15:17:44 +00:00

Owner

Fixes swamp-club #2873: stages in the swamp-club-swamp-extensions example definition read stale inputs.

notify thanks the author with the change-summary summary (what was committed), falling back to the plan's only when there is none.
plan-review injects the last plan-review and plan-feedback; its prompt asks the reviewer to carry each earlier finding over by id and mark it resolved only when the new plan resolves it.
conformance-review injects plan-review, so a deviation the approving review asked for is justified by its finding.
plan.submit refuses a plan recorded in an earlier cycle. The issue suggested artifact-fresh, but that gate needs a reviews: subject and plan reviews nothing, so this is a cel gate on the plan's stage and cycle, guarded so a missing plan gives only the plain "not recorded" refusal.

Tests: new saved scenario plan-resubmit-needs-new-plan pins the cycle-2 refusal; the swamp-extensions walk test takes a decline/revise round and asserts the plan-review (cycle 2), conformance-review and notify packets. A shared factories_test assertion now checks the reviewer gets no plan-feedback write path rather than no mention of it. No engine change.

Verified with verify-build 46eca128 and verify-reviews 28c110e8 at 91d463bdf; attestation 6928f98c posted.

🤖 Generated with Claude Code

Fixes swamp-club #2873: stages in the swamp-club-swamp-extensions example definition read stale inputs. - **notify** thanks the author with the `change-summary` summary (what was committed), falling back to the plan's only when there is none. - **plan-review** injects the last `plan-review` and `plan-feedback`; its prompt asks the reviewer to carry each earlier finding over by id and mark it resolved only when the new plan resolves it. - **conformance-review** injects `plan-review`, so a deviation the approving review asked for is justified by its finding. - **plan.submit** refuses a plan recorded in an earlier cycle. The issue suggested `artifact-fresh`, but that gate needs a `reviews:` subject and `plan` reviews nothing, so this is a `cel` gate on the plan's stage and cycle, guarded so a missing plan gives only the plain "not recorded" refusal. Tests: new saved scenario `plan-resubmit-needs-new-plan` pins the cycle-2 refusal; the swamp-extensions walk test takes a decline/revise round and asserts the plan-review (cycle 2), conformance-review and notify packets. A shared factories_test assertion now checks the reviewer gets no plan-feedback *write path* rather than no mention of it. No engine change. Verified with verify-build `46eca128` and verify-reviews `28c110e8` at 91d463bdf; attestation `6928f98c` posted. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

seth added 1 commit

2026-10-01 15:17:44 +00:00

fix(gatorwalk-factory): swamp-club-swamp-extensions stages read current inputs (swamp-club #2873 )

CI / Review Integrity (pull_request) Successful in 1m17s

Details

CI / Validate Attestation (pull_request) Successful in 1m17s

Details

91d463bdf4

- notify thanks the author with the change-summary's summary (what was
  committed), falling back to the plan's only when there is none.
- plan-review injects the last plan-review and plan-feedback, and its
  prompt asks it to say whether each earlier finding is resolved.
- conformance-review injects plan-review, so a deviation the approving
  review asked for is justified by its finding.
- plan.submit refuses a plan recorded in an earlier cycle. The issue
  suggested artifact-fresh, but that gate needs a reviews: subject and plan
  reviews nothing, so this is a cel gate on the plan's stage and cycle.
- New scenario plan-resubmit-needs-new-plan pins the refusal at cycle 2;
  the swamp-extensions walk test now takes a revise round and checks the
  plan-review (cycle 2), conformance-review and notify packets.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

seth merged commit 5c67b15eeb into main

2026-10-01 15:19:57 +00:00

seth deleted branch cue/2873-gatorwalk-factory-swamp

2026-10-01 15:19:58 +00:00

seth referenced this pull request from a commit

2026-10-01 15:19:59 +00:00

fix(gatorwalk-factory): swamp-club-swamp-extensions stages read current inputs (swamp-club #2873) (#411)