feat(gatorwalk-factory): validate warns on a way back with no description (swamp-club #2840) #410

Merged
seth merged 1 commit from cue/2840-gatorwalk-factory-validate into main 2026-10-01 15:11:12 +00:00
Owner

Closes swamp-club #2840.

What

validate now warns, as undescribed-way-back, about a way back with no description. A way back is a live, non-global transition inside a loop to the same stage or one earlier in the file; every loop has at least one. Authoring rule 1 asks each way back to say why it goes back, and nothing checked it.

The issue's second proposal, a product with no schema, is already a schema error (since #2576), so it is not added.

Also

  • Every way back in the shipped examples (starter, build-swamp-extension, swamp-club-swamp-extensions) and the test factories now has a description, so none gains a warning; examples_test EXPECTED is unchanged.
  • Test fixtures with an undescribed way back got a description so each test keeps asserting what it was written for.
  • New graph tests (missing/blank/described, self-transition, forward and global edges, backward edge closing no loop) and a validate-log test.
  • authoring.md findings table and rule 1; both finding lists in DESIGN.md.
  • Studio bundle rebuilt (Design mode runs the graph analysis in the page).

Verification

Attestation f1a8f159-e49b-4224-878e-2f9e8a897e0a for 8ec09ead4: verify-build 034f42c5, verify-reviews 9b66dbcd, gate allPassed (12 succeeded, 2 guarded skips).

🤖 Generated with Claude Code

Closes swamp-club #2840. ## What `validate` now warns, as `undescribed-way-back`, about a way back with no description. A way back is a live, non-global transition inside a loop to the same stage or one earlier in the file; every loop has at least one. Authoring rule 1 asks each way back to say why it goes back, and nothing checked it. The issue's second proposal, a product with no schema, is already a schema error (since #2576), so it is not added. ## Also - Every way back in the shipped examples (starter, build-swamp-extension, swamp-club-swamp-extensions) and the test factories now has a description, so none gains a warning; `examples_test` EXPECTED is unchanged. - Test fixtures with an undescribed way back got a description so each test keeps asserting what it was written for. - New graph tests (missing/blank/described, self-transition, forward and global edges, backward edge closing no loop) and a validate-log test. - `authoring.md` findings table and rule 1; both finding lists in `DESIGN.md`. - Studio bundle rebuilt (Design mode runs the graph analysis in the page). ## Verification Attestation `f1a8f159-e49b-4224-878e-2f9e8a897e0a` for `8ec09ead4`: verify-build `034f42c5`, verify-reviews `9b66dbcd`, gate allPassed (12 succeeded, 2 guarded skips). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
feat(gatorwalk-factory): validate warns on a way back with no description (swamp-club #2840)
All checks were successful
CI / Validate Attestation (pull_request) Successful in 1m5s
CI / Review Integrity (pull_request) Successful in 1m12s
8ec09ead48
A transition inside a loop to the same or an earlier stage in the file is a
way back. validate now warns, as undescribed-way-back, when one has no
description saying why it goes back (authoring rule 1). Global transitions
and backward edges that close no loop are not ways back.

The shipped examples and test factories describe every way back, so they
carry no new warning. The issue's second check, a product with no schema,
is already a schema error and is not added.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
seth merged commit 054f0f9519 into main 2026-10-01 15:11:12 +00:00
seth deleted branch cue/2840-gatorwalk-factory-validate 2026-10-01 15:11:12 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
swamp-club/swamp-extensions!410
No description provided.