fix(verification): replace invalid UUID in verify-reviews workflow (#1906) #249

Merged

stack72 merged 1 commit from worktree-1906 into main 2026-08-31 14:40:30 +00:00

Conversation 0 Commits 1 Files changed 1 +1 -1

stack72 commented 2026-08-31 14:34:32 +00:00

Owner

Copy link

Summary

The verify-reviews workflow at verification/workflow-verify-reviews.yaml fails to load with a UUID schema validation error on the id field, silently blocking all pre-PR agent review verification runs.

Root Cause

The workflow's id field was set to e5f6a7b8-9c0d-1e2f-3a4b-5c6d7e8f9a0b — a sequential hex placeholder created when the file was first added in commit df42ce656. This value is not a valid RFC 4122 UUID:

• The variant nibble (byte 9, position 0) is 3, but the swamp workflow engine's UUID regex requires [89abAB] (the RFC 4122 variant)
• The validation regex: /^([0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[1-8][0-9a-fA-F]{3}-[89abAB][0-9a-fA-F]{3}-[0-9a-fA-F]{12}|...)$/

The workflow was never smoke-tested after creation (the test plan checkbox in the original PR was unchecked), so the invalid UUID went unnoticed.

Fix

Replace the placeholder with a valid UUID v4 (94c0688e-1bf0-4f4b-b1b2-cb349e4abe36), generated via uuidgen. This is a one-line change to the id: field on line 1.

Impact

• Before: SWAMP_WORKFLOWS_DIR=verification swamp workflow validate verify-reviews fails — the engine logs "Skipping broken extension workflow" and the workflow is invisible
• After: Validation passes all 23 checks (schema, unique names, dependencies, step inputs)
• Blast radius: Only verify-reviews is affected; verify-build was already valid (its UUID a1b2c3d4-... has correct version/variant bytes)

Why This Is Correct

The UUID v4 94c0688e-1bf0-4f4b-b1b2-cb349e4abe36 satisfies all RFC 4122 constraints:

• Version nibble (position 13): 4 ✓
• Variant nibble (position 19): b (matches [89abAB]) ✓
• Full match against the swamp engine's validation regex ✓

Verification

$ SWAMP_WORKFLOWS_DIR=.../worktree/verification swamp workflow validate verify-reviews
Validating: verify-reviews
  ✓ Schema validation
  ✓ Unique job names
  ... (23 total)
Summary: 23 passed
Result: PASSED

Closes #1906

Co-Authored-By: Paul Stack public@paulstack.co.uk
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

## Summary The `verify-reviews` workflow at `verification/workflow-verify-reviews.yaml` fails to load with a UUID schema validation error on the `id` field, silently blocking all pre-PR agent review verification runs. ## Root Cause The workflow's `id` field was set to `e5f6a7b8-9c0d-1e2f-3a4b-5c6d7e8f9a0b` — a sequential hex placeholder created when the file was first added in commit df42ce656. This value is not a valid RFC 4122 UUID: - The **variant nibble** (byte 9, position 0) is `3`, but the swamp workflow engine's UUID regex requires `[89abAB]` (the RFC 4122 variant) - The validation regex: `/^([0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[1-8][0-9a-fA-F]{3}-[89abAB][0-9a-fA-F]{3}-[0-9a-fA-F]{12}|...)$/` The workflow was never smoke-tested after creation (the test plan checkbox in the original PR was unchecked), so the invalid UUID went unnoticed. ## Fix Replace the placeholder with a valid UUID v4 (`94c0688e-1bf0-4f4b-b1b2-cb349e4abe36`), generated via `uuidgen`. This is a one-line change to the `id:` field on line 1. ## Impact - **Before**: `SWAMP_WORKFLOWS_DIR=verification swamp workflow validate verify-reviews` fails — the engine logs "Skipping broken extension workflow" and the workflow is invisible - **After**: Validation passes all 23 checks (schema, unique names, dependencies, step inputs) - **Blast radius**: Only `verify-reviews` is affected; `verify-build` was already valid (its UUID `a1b2c3d4-...` has correct version/variant bytes) ## Why This Is Correct The UUID v4 `94c0688e-1bf0-4f4b-b1b2-cb349e4abe36` satisfies all RFC 4122 constraints: - Version nibble (position 13): `4` ✓ - Variant nibble (position 19): `b` (matches `[89abAB]`) ✓ - Full match against the swamp engine's validation regex ✓ ## Verification ``` $ SWAMP_WORKFLOWS_DIR=.../worktree/verification swamp workflow validate verify-reviews Validating: verify-reviews ✓ Schema validation ✓ Unique job names ... (23 total) Summary: 23 passed Result: PASSED ``` Closes #1906 Co-Authored-By: Paul Stack <public@paulstack.co.uk> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

stack72 added 1 commit 2026-08-31 14:34:33 +00:00

fix(verification): replace invalid UUID in verify-reviews workflow (#1906) ... b7460a52cc

The workflow id 'e5f6a7b8-9c0d-1e2f-3a4b-5c6d7e8f9a0b' was a sequential
hex placeholder with an invalid RFC 4122 variant byte (0x3 instead of
0x8-0xb), causing the swamp workflow engine to silently skip the file at
load time. Replace with a valid UUID v4.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

stack72 merged commit 9ef573137b into main 2026-08-31 14:40:30 +00:00

stack72 deleted branch worktree-1906 2026-08-31 14:40:31 +00:00

stack72 referenced this pull request from a commit 2026-08-31 14:40:32 +00:00

fix(verification): replace invalid UUID in verify-reviews workflow (#1906) (#249)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

swamp-club/swamp-extensions!249

No description provided.