docs(ssh): correct stale selector descriptions in manifest (#485 follow-up) #16
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/485-followup-docs"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Follow-up to #15. The
2026.05.29.1release fixed the selector behavior but left two stale selector descriptions inmanifest.yamlthat still described the removed bare-CEL form — so the published registry docs contradicted the shipped behavior:## Highlights: "Three selector forms:"all", an explicit name list, or a bare CEL string evaluated per host"--input hosts='"prod" in host.tags'My docs-drift sweep in #15 updated the manifest's top
descriptionand all README sites but missed these two blocks lower in the manifest.Changes
name:/tag:/cel:prefixes, and the bare-CEL deprecation.hosts='tag:prod'.2026.05.29.1→2026.05.29.2(manifest and modelversion) with a matchingupgradesentry, so the corrected version is picked up as current. Docs-only — identityupgradeAttributes, no code, schema, or behavior change.Verification
ssh/):deno check/lint/fmt --checkclean, 204 tests pass,deno install --frozenclean.manifest.yamlandREADME.md— no remaining unprefixed bare-CEL examples or "Three selector forms" phrasing.2026.05.29.2as current and a fresh instance pinstypeVersion: 2026.05.29.2; the19.1 → 29.1 → 29.2upgrade chain is intact (identity migrations).🤖 Generated with Claude Code
The 2026.05.29.1 release fixed the selector behavior but the manifest's `Highlights` and usage example still described the removed bare-CEL form ("Three selector forms ... a bare CEL string evaluated per host"). The published docs therefore contradicted the shipped behavior. - Rewrite the Highlights selector bullet to describe bare name/tag, name:/tag:/cel: prefixes, and the bare-CEL deprecation. - Fix the usage example to use `hosts='tag:prod'` instead of bare CEL. - Bump version to 2026.05.29.2 (manifest + model) with a matching `upgrades` entry so the corrected version is picked up as current. Docs-only — identity upgradeAttributes, no code or schema change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>Code Review
Blocking Issues
None.
Suggestions
ssh.ts: consolidate the twoimport … from "./_lib/schemas.ts"blocks — the value imports (line 36–48) and the type imports (line 49–55) both pull from the same source file. A singleimport { ApplyArgsSchema, …, type CopyArgs, … } from "./_lib/schemas.ts"would be marginally cleaner, though this is purely stylistic and doesn't block merge.Summary: Docs-only version bump from
2026.05.29.1→2026.05.29.2. Bothmanifest.yamlandssh.tsversions are consistent. The newupgradesentry for2026.05.29.2correctly uses an identityupgradeAttributestransform and accurately describes the change (no code/schema delta). The manifest'sHighlightsselector bullet and usage example now accurately reflect thename:/tag:/cel:prefix behavior introduced in2026.05.29.1, removing the stale bare-CEL description. Noanytypes introduced, named export only (export const model), no default export. No test changes needed for a docs-only bump.