chore: regenerate models from upstream schemas #103

Merged

stack72 merged 1 commit from automated/regenerate-models into main 2026-07-14 19:55:30 +00:00

Conversation 1 Commits 1 Files changed 84 +5722 -177

stack72 commented 2026-07-14 06:12:57 +00:00

Owner

Copy link

Summary

Automated regeneration of extension models from upstream provider schemas.

Schema Sources

• AWS: CloudFormation Resource Schema
• GCP: Google Discovery Documents
• Cloudflare: Cloudflare OpenAPI spec
• Hetzner: Hetzner Cloud OpenAPI spec
• DigitalOcean: DigitalOcean OpenAPI spec

Review Notes

• Files under model/ are auto-generated — review the manifest.yaml diffs for version changes
• CalVer versioning with content-based change detection ensures versions only bump when content changes
• Publishing happens automatically when this PR is merged (via the publish workflow)

## Summary Automated regeneration of extension models from upstream provider schemas. ### Schema Sources - **AWS**: CloudFormation Resource Schema - **GCP**: Google Discovery Documents - **Cloudflare**: Cloudflare OpenAPI spec - **Hetzner**: Hetzner Cloud OpenAPI spec - **DigitalOcean**: DigitalOcean OpenAPI spec ### Review Notes - Files under `model/` are auto-generated — review the `manifest.yaml` diffs for version changes - CalVer versioning with content-based change detection ensures versions only bump when content changes - Publishing happens automatically when this PR is merged (via the publish workflow)

stack72 added 1 commit 2026-07-14 06:12:58 +00:00

chore: regenerate models from upstream schemas (2026-07-14) 20dfa226df

stack72 commented 2026-07-14 06:23:23 +00:00

Author

Owner

Copy link

Code Review

Blocking Issues

None.

Suggestions

1. Review instructions gap — nightly regeneration isn't explicitly listed as a legitimate case for model-only changes.
   The CLAUDE.md review rules list two cases where model/ may change without codegen/ changes: (a) codegen regeneration where codegen/ also changes, and (b) version-only bumps via bump-versions. This PR falls into neither category by strict reading — it has new files and new schema fields, not just version/upgrade entries, and no codegen/ files changed.

   However, all evidence points to this being a legitimate output of the nightly regenerate-models CI workflow (recently expanded to include Cloudflare in PR #102):

   • Every new and modified file carries the // Auto-generated … Do not edit manually header.
   • The single commit is titled chore: regenerate models from upstream schemas (2026-07-14), matching the nightly workflow's commit convention.
   • Content patterns (schema structure, credential handling, version CalVer dating) are mechanically consistent across all 84 files — not hand-authoring at scale.
   • New packages (data-security, one, registrar-sandbox) include all required scaffolding: deno.json, deno.lock, manifest.yaml, LICENSE.txt, README.md.
   • deno.json imports and deno.lock pin zod to an exact version (4.3.6), consistent with the project rule.

   Recommendation: Update the review instructions in CLAUDE.md (or a separate review guide) to explicitly list nightly schema regeneration — where only model/ changes but the codegen pipeline code is unchanged — as a third legitimate case, so future automated reviews don't treat this workflow as suspect.

## Code Review ### Blocking Issues None. ### Suggestions 1. **Review instructions gap — nightly regeneration isn't explicitly listed as a legitimate case for model-only changes.** The `CLAUDE.md` review rules list two cases where `model/` may change without `codegen/` changes: (a) codegen regeneration where `codegen/` also changes, and (b) version-only bumps via `bump-versions`. This PR falls into neither category by strict reading — it has new files and new schema fields, not just version/upgrade entries, and no `codegen/` files changed. However, all evidence points to this being a legitimate output of the nightly `regenerate-models` CI workflow (recently expanded to include Cloudflare in PR #102): - Every new and modified file carries the `// Auto-generated … Do not edit manually` header. - The single commit is titled `chore: regenerate models from upstream schemas (2026-07-14)`, matching the nightly workflow's commit convention. - Content patterns (schema structure, credential handling, version CalVer dating) are mechanically consistent across all 84 files — not hand-authoring at scale. - New packages (`data-security`, `one`, `registrar-sandbox`) include all required scaffolding: `deno.json`, `deno.lock`, `manifest.yaml`, `LICENSE.txt`, `README.md`. - `deno.json` imports and `deno.lock` pin `zod` to an exact version (`4.3.6`), consistent with the project rule. **Recommendation:** Update the review instructions in `CLAUDE.md` (or a separate review guide) to explicitly list nightly schema regeneration — where only `model/` changes but the codegen pipeline code is unchanged — as a third legitimate case, so future automated reviews don't treat this workflow as suspect.

stack72 merged commit 48f40a0e22 into main 2026-07-14 19:55:30 +00:00

stack72 deleted branch automated/regenerate-models 2026-07-14 19:55:31 +00:00

stack72 referenced this pull request from a commit 2026-07-14 19:55:31 +00:00

chore: regenerate models from upstream schemas (#103)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

swamp-club/swamp-extensions!103

No description provided.