feat(gatorwalk-factory): keep a person's plan feedback and hand it to the next plan (swamp-club #2770) #396

Merged

seth merged 1 commit from cue/2770-gatorwalk-factory-keep into main

2026-09-30 22:18:53 +00:00

seth commented

2026-09-30 22:16:42 +00:00

Owner

Fixes swamp-club #2770.

A person's feedback on a plan was lost in gatorwalk: revise took no reason, the next plan was handed only the classification, and the Lab never saw the feedback.

What changes

The three example factories (swamp-club-swamp-extensions, build-swamp-extension, starter): plan-review declares plan-feedback evidence, recorded by a person. revise needs it in the current pass. plan injects the last plan, its review and the feedback, and the revised plan lists every round in an optional feedbackIncorporated, which plan_revised carries to the Lab.
recordedBy: person on evidence. The dispatch packet and subagent prompts leave it out, status lists it (a person records: plan-feedback), the design page marks it, and a saved scenario records it as the person.
Awaiting: recording a person's evidence after a decline is not rework, so after a declined plan and the feedback only revise waits on the person.
Graph analysis: an inject whose every producer is in the injecting stage's own loop (context from an earlier pass) is no longer a product-missing-on-path warning. A producer upstream but outside the loop still warns. The examples keep exactly their previous warnings.
Docs: driving.md, SKILL.md, the swamp-club mapping, the worked example, README and DESIGN.md (with a decision-log entry).

Tests

Unit tests for each engine change, each confirmed to fail without it.
Walk tests on the real engine for all three factories; new plan-feedback saved scenarios; plan-churn updated.
The Lab walk against the swamp-club fake shows plan_revised carrying the feedback.
The worked example runs as written in the integration suite.

Verification

verify-build f1306e86 and verify-reviews 55d7cefa passed at b8c68220b5027fb5e94a7fea82d96c727a08b519; the attestation is posted. The reviews left two low findings, not addressed here: an agent could record plan-feedback itself (only the skill text prevents it), and after revise → rework the planner could add the same feedback to feedbackIncorporated twice.

🤖 Generated with Claude Code

Fixes swamp-club #2770. A person's feedback on a plan was lost in gatorwalk: `revise` took no reason, the next plan was handed only the classification, and the Lab never saw the feedback. ## What changes - **The three example factories** (swamp-club-swamp-extensions, build-swamp-extension, starter): `plan-review` declares `plan-feedback` evidence, recorded by a person. `revise` needs it in the current pass. `plan` injects the last plan, its review and the feedback, and the revised plan lists every round in an optional `feedbackIncorporated`, which `plan_revised` carries to the Lab. - **`recordedBy: person` on evidence.** The dispatch packet and subagent prompts leave it out, `status` lists it (`a person records: plan-feedback`), the design page marks it, and a saved scenario records it as the person. - **Awaiting:** recording a person's evidence after a decline is not rework, so after a declined plan and the feedback only `revise` waits on the person. - **Graph analysis:** an inject whose every producer is in the injecting stage's own loop (context from an earlier pass) is no longer a `product-missing-on-path` warning. A producer upstream but outside the loop still warns. The examples keep exactly their previous warnings. - Docs: driving.md, SKILL.md, the swamp-club mapping, the worked example, README and DESIGN.md (with a decision-log entry). ## Tests - Unit tests for each engine change, each confirmed to fail without it. - Walk tests on the real engine for all three factories; new `plan-feedback` saved scenarios; `plan-churn` updated. - The Lab walk against the swamp-club fake shows `plan_revised` carrying the feedback. - The worked example runs as written in the integration suite. ## Verification verify-build `f1306e86` and verify-reviews `55d7cefa` passed at `b8c68220b5027fb5e94a7fea82d96c727a08b519`; the attestation is posted. The reviews left two low findings, not addressed here: an agent could record `plan-feedback` itself (only the skill text prevents it), and after revise → rework the planner could add the same feedback to `feedbackIncorporated` twice. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

seth added 1 commit

2026-09-30 22:16:42 +00:00

feat(gatorwalk-factory): keep a person's plan feedback and hand it to the next plan (swamp-club #2770 )

CI / Review Integrity (pull_request) Successful in 45s

Details

CI / Validate Attestation (pull_request) Successful in 50s

Details

b8c68220b5

A person's feedback on a plan was lost: revise took no reason, the next plan
was handed only the classification, and the Lab never saw the feedback.

- plan-review declares plan-feedback evidence, recorded by a person, and
  revise needs it in the current pass. plan injects the last plan, its review
  and the feedback, and the revised plan lists every round in the optional
  feedbackIncorporated, which plan_revised carries to the Lab. All three
  example factories with a plan loop take it.
- Evidence may be declared recordedBy: person. The dispatch packet and
  subagent prompts leave it out, status lists it ("a person records:"), the
  design page marks it, a scenario records it as the person, and recording it
  after a decline is not rework.
- Graph analysis no longer warns about an inject whose every producer is in
  the injecting stage's own loop: context from an earlier pass.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

seth merged commit 29d0fdda41 into main

2026-09-30 22:18:53 +00:00

seth deleted branch cue/2770-gatorwalk-factory-keep

2026-09-30 22:18:54 +00:00

seth referenced this pull request from a commit

2026-09-30 22:18:55 +00:00

feat(gatorwalk-factory): keep a person's plan feedback and hand it to the next plan (swamp-club #2770) (#396)

seth referenced this pull request

2026-09-30 22:42:24 +00:00

fix(gatorwalk-factory): a plan adds the person's feedback to feedbackIncorporated only once (swamp-club #2852) #398