chore: regenerate models from upstream schemas #47

Merged

stack72 merged 1 commit from automated/regenerate-models into main 2026-06-09 13:45:45 +00:00

Conversation 1 Commits 1 Files changed 32 +406 -1196

stack72 commented 2026-06-09 06:11:49 +00:00

Owner

Copy link

Summary

Automated regeneration of extension models from upstream provider schemas.

Schema Sources

• AWS: CloudFormation Resource Schema
• GCP: Google Discovery Documents
• Hetzner: Hetzner Cloud OpenAPI spec
• DigitalOcean: DigitalOcean OpenAPI spec

Review Notes

• Files under model/ are auto-generated — review the manifest.yaml diffs for version changes
• CalVer versioning with content-based change detection ensures versions only bump when content changes
• Publishing happens automatically when this PR is merged (via the publish workflow)

## Summary Automated regeneration of extension models from upstream provider schemas. ### Schema Sources - **AWS**: CloudFormation Resource Schema - **GCP**: Google Discovery Documents - **Hetzner**: Hetzner Cloud OpenAPI spec - **DigitalOcean**: DigitalOcean OpenAPI spec ### Review Notes - Files under `model/` are auto-generated — review the `manifest.yaml` diffs for version changes - CalVer versioning with content-based change detection ensures versions only bump when content changes - Publishing happens automatically when this PR is merged (via the publish workflow)

stack72 added 1 commit 2026-06-09 06:11:49 +00:00

chore: regenerate models from upstream schemas (2026-06-09) 0eb4db1b23

stack72 commented 2026-06-09 06:22:42 +00:00

Author

Owner

Copy link

Code Review

Blocking Issues

1. Model files changed without corresponding codegen/ changes.
   All changed files are under model/, and the diff includes substantive schema changes well beyond version/upgrade entries — new schema fields (channelToAffiliateProgramLink, youtubeChannelPackDetails, SessionConfigurationSchema, StreamingConfigurationSchema), enum additions (EXCHANGE_EXTE, TARGETING_TYPE_YOUTUBE_CHANNEL_PACK, channelToAffiliateProgramLink), description enrichment throughout, and three file deletions (dfareporting/inventoryitems.ts, dfareporting/orders.ts, dfareporting/projects.ts). No codegen/ files are present in the diff.

   Per the review rules: "If model files have changes beyond version/upgrade entries and no codegen/ changes exist, flag that as a blocking issue (hand-edited generated code)."

   If this was produced by running deno task fetch-schema:<provider> followed by deno task generate:<provider> against updated upstream schemas (with no pipeline code changes), that is a legitimate workflow — but it is indistinguishable from hand-editing from this PR alone. Please confirm the models were regenerated via the codegen pipeline, or add a note in the PR description confirming so.

2. Inaccurate upgrade description in thirdpartylinks.ts.
   model/gcp/youtube/extensions/models/thirdpartylinks.ts adds a new channelToAffiliateProgramLink sub-object to the schema (a meaningful structural addition), but the new upgrade entry records description: "No schema changes". Compare with partners_targetingtypes_assignedtargetingoptions.ts in the same PR, which correctly records "Added: youtubeChannelPackDetails". If this is generated, the generator has an inconsistency; if it was written manually, it is incorrect.

Suggestions

1. The PR description / release notes could explicitly state which upstream schema snapshots were used (e.g., CloudFormation schema date, GCP discovery doc revision) to make future audits easier.

## Code Review ### Blocking Issues 1. **Model files changed without corresponding codegen/ changes.** All changed files are under `model/`, and the diff includes substantive schema changes well beyond version/upgrade entries — new schema fields (`channelToAffiliateProgramLink`, `youtubeChannelPackDetails`, `SessionConfigurationSchema`, `StreamingConfigurationSchema`), enum additions (`EXCHANGE_EXTE`, `TARGETING_TYPE_YOUTUBE_CHANNEL_PACK`, `channelToAffiliateProgramLink`), description enrichment throughout, and three file deletions (`dfareporting/inventoryitems.ts`, `dfareporting/orders.ts`, `dfareporting/projects.ts`). No `codegen/` files are present in the diff. Per the review rules: *"If model files have changes beyond version/upgrade entries and no codegen/ changes exist, flag that as a blocking issue (hand-edited generated code)."* If this was produced by running `deno task fetch-schema:<provider>` followed by `deno task generate:<provider>` against updated upstream schemas (with no pipeline code changes), that is a legitimate workflow — but it is indistinguishable from hand-editing from this PR alone. Please confirm the models were regenerated via the codegen pipeline, or add a note in the PR description confirming so. 2. **Inaccurate upgrade description in `thirdpartylinks.ts`.** `model/gcp/youtube/extensions/models/thirdpartylinks.ts` adds a new `channelToAffiliateProgramLink` sub-object to the schema (a meaningful structural addition), but the new upgrade entry records `description: "No schema changes"`. Compare with `partners_targetingtypes_assignedtargetingoptions.ts` in the same PR, which correctly records `"Added: youtubeChannelPackDetails"`. If this is generated, the generator has an inconsistency; if it was written manually, it is incorrect. ### Suggestions 1. The PR description / release notes could explicitly state which upstream schema snapshots were used (e.g., CloudFormation schema date, GCP discovery doc revision) to make future audits easier.

stack72 merged commit 5aca4fefed into main 2026-06-09 13:45:45 +00:00

stack72 deleted branch automated/regenerate-models 2026-06-09 13:45:45 +00:00

stack72 referenced this pull request from a commit 2026-06-09 13:45:45 +00:00

chore: regenerate models from upstream schemas (#47)

stack72 referenced this pull request 2026-06-12 06:24:24 +00:00

chore: regenerate models from upstream schemas #51

stack72 referenced this pull request 2026-06-16 06:23:32 +00:00

chore: regenerate models from upstream schemas #55

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

swamp-club/swamp-extensions!47

No description provided.