fix(container-image): add missing upgradeAttributes to upgrade entry #232

Merged

stack72 merged 2 commits from fix/1817-container-image-upgrade-attributes into main 2026-08-25 16:00:05 +00:00

Conversation 4 Commits 2 Files changed 2 +8 -2

stack72 commented 2026-08-25 15:18:14 +00:00

Owner

Copy link

Summary

• Add the missing upgradeAttributes field to the 2026.08.25.1 upgrade entry in container_image.ts — a no-op (old) => old since the upgrade only added optional method inputs (privileged, extraArgs), no model attributes changed
• The field is required by the schema validator; its absence made @swamp/container-image@2026.08.25.1 completely uninstallable (upgrades.0.upgradeAttributes: Invalid input)
• Filed #1822 separately for Defect 2 (swamp doctor bundle cache staleness) reported in the same issue

Test plan

• deno check passes
• deno lint passes
• deno fmt --check passes
• All 85 tests pass (37 runner, 19 schema, 29 operation)
• deno install --frozen passes (lockfile consistent)

Closes #1817

🤖 Generated with Claude Code

## Summary - Add the missing `upgradeAttributes` field to the `2026.08.25.1` upgrade entry in `container_image.ts` — a no-op `(old) => old` since the upgrade only added optional method inputs (`privileged`, `extraArgs`), no model attributes changed - The field is required by the schema validator; its absence made `@swamp/container-image@2026.08.25.1` completely uninstallable (`upgrades.0.upgradeAttributes: Invalid input`) - Filed #1822 separately for Defect 2 (swamp doctor bundle cache staleness) reported in the same issue ## Test plan - [x] `deno check` passes - [x] `deno lint` passes - [x] `deno fmt --check` passes - [x] All 85 tests pass (37 runner, 19 schema, 29 operation) - [x] `deno install --frozen` passes (lockfile consistent) Closes #1817 🤖 Generated with [Claude Code](https://claude.com/claude-code)

stack72 added 1 commit 2026-08-25 15:18:14 +00:00

fix(container-image): add missing upgradeAttributes to upgrade entry (#1817) ... e6cb0229e3

The upgrade entry for version 2026.08.25.1 was missing the required
upgradeAttributes field, causing schema validation to fail and making
the extension completely uninstallable. The upgrade only added optional
method inputs (privileged, extraArgs) so the attribute transform is a
no-op.

Also filed #1822 for the separate swamp doctor bundle cache staleness
defect reported in the same issue.

Closes #1817

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

stack72 commented 2026-08-25 15:22:49 +00:00

Author

Owner

Copy link

Code Review

Blocking Issues

None.

Suggestions

None.

---

The change adds the missing upgradeAttributes identity function to the 2026.08.25.1 upgrade entry in container-image/extensions/models/container_image.ts. The fix is correct and minimal:

• (old: Record<string, unknown>) => old is the appropriate pass-through for a non-breaking upgrade where no attribute migration is needed.
• No any types; Record<string, unknown> is properly typed.
• The file is hand-written (not under model/), so the no-hand-edit rule does not apply.
• Named export is maintained (export const model).
• No security, correctness, or testing concerns introduced by this one-line change.

## Code Review ### Blocking Issues None. ### Suggestions None. --- The change adds the missing `upgradeAttributes` identity function to the `2026.08.25.1` upgrade entry in `container-image/extensions/models/container_image.ts`. The fix is correct and minimal: - `(old: Record<string, unknown>) => old` is the appropriate pass-through for a non-breaking upgrade where no attribute migration is needed. - No `any` types; `Record<string, unknown>` is properly typed. - The file is hand-written (not under `model/`), so the no-hand-edit rule does not apply. - Named export is maintained (`export const model`). - No security, correctness, or testing concerns introduced by this one-line change.

stack72 commented 2026-08-25 15:24:10 +00:00

Author

Owner

Copy link

Adversarial Review

Critical / High

None.

Medium

None.

Low

None.

Verdict

PASS — The PR adds a single missing upgradeAttributes property to the upgrade entry at container-image/extensions/models/container_image.ts:79. The identity function (old) => old is the correct pass-through for upgrades that add optional fields with no attribute migration needed (matching the established pattern used across cve/mini-shai-hulud, cve/researcher, and all generated models). The fix is minimal and correct.

## Adversarial Review ### Critical / High None. ### Medium None. ### Low None. ### Verdict **PASS** — The PR adds a single missing `upgradeAttributes` property to the upgrade entry at `container-image/extensions/models/container_image.ts:79`. The identity function `(old) => old` is the correct pass-through for upgrades that add optional fields with no attribute migration needed (matching the established pattern used across `cve/mini-shai-hulud`, `cve/researcher`, and all generated models). The fix is minimal and correct.

stack72 added 1 commit 2026-08-25 15:34:06 +00:00

fix(container-image): bump to 2026.08.25.2 with corrected upgrade chain ... 287481be2b

Version bump so the fix can be published as a new release. Adds a
second upgrade entry (2026.08.25.2) for the installation fix itself.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

stack72 commented 2026-08-25 15:40:39 +00:00

Author

Owner

Copy link

Code Review

Blocking Issues

None.

Suggestions

None.

---

This is a clean, minimal fix. The PR adds the missing upgradeAttributes identity function to the 2026.08.25.1 upgrade entry (the root cause of the installation failure) and bumps to 2026.08.25.2 with its own identity upgrade entry. The version is consistent between container_image.ts and manifest.yaml. No hand-edited generated files, no type issues, no security concerns.

## Code Review ### Blocking Issues None. ### Suggestions None. --- This is a clean, minimal fix. The PR adds the missing `upgradeAttributes` identity function to the `2026.08.25.1` upgrade entry (the root cause of the installation failure) and bumps to `2026.08.25.2` with its own identity upgrade entry. The version is consistent between `container_image.ts` and `manifest.yaml`. No hand-edited generated files, no type issues, no security concerns.

stack72 commented 2026-08-25 15:41:22 +00:00

Author

Owner

Copy link

Adversarial Review

Critical / High

No critical or high severity issues found.

Medium

No medium severity issues found.

Low

No low severity issues found.

Verdict

PASS — Minimal, correct fix. The PR adds the missing upgradeAttributes identity callback to the 2026.08.25.1 upgrade entry (which was causing installation failures), adds a new 2026.08.25.2 upgrade entry documenting the fix, and bumps the version consistently in both container_image.ts:72 and manifest.yaml:3. The identity function (old) => old is the correct transform for upgrades that don't alter the attribute schema. Version strings are consistent across both files. The upgrade chain is ordered correctly. Nothing to flag.

## Adversarial Review ### Critical / High No critical or high severity issues found. ### Medium No medium severity issues found. ### Low No low severity issues found. ### Verdict **PASS** — Minimal, correct fix. The PR adds the missing `upgradeAttributes` identity callback to the `2026.08.25.1` upgrade entry (which was causing installation failures), adds a new `2026.08.25.2` upgrade entry documenting the fix, and bumps the version consistently in both `container_image.ts:72` and `manifest.yaml:3`. The identity function `(old) => old` is the correct transform for upgrades that don't alter the attribute schema. Version strings are consistent across both files. The upgrade chain is ordered correctly. Nothing to flag.

stack72 merged commit d9ef4ecbb0 into main 2026-08-25 16:00:05 +00:00

stack72 deleted branch fix/1817-container-image-upgrade-attributes 2026-08-25 16:00:05 +00:00

stack72 referenced this pull request from a commit 2026-08-25 16:00:06 +00:00

fix(container-image): add missing upgradeAttributes to upgrade entry (#232)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

swamp-club/swamp-extensions!232

No description provided.