fix(deno-runner): fail step when command exits non-zero #219

Merged
stack72 merged 1 commit from worktree-velvety-petting-floyd into main 2026-08-23 20:50:31 +00:00
Owner

Summary

  • The run and task methods now throw when the underlying deno command exits with a non-zero exit code, causing the workflow step to correctly report failure
  • The commandResult resource is still written before the throw so output is retrievable via swamp data get for debugging
  • Version bumped to 2026.08.23.1 with upgrades entry, manifest and README updated to document the new behavior

Test plan

  • 3 new tests verify run and task throw on non-zero exit while still persisting the output resource
  • All 33 existing + new tests pass
  • deno check, deno lint, deno fmt --check all clean
  • deno install --frozen passes (lockfile unchanged)
  • Local end-to-end via swamp extension source add to verify upgrade path from 2026.08.22.1

🤖 Generated with Claude Code

## Summary - The `run` and `task` methods now throw when the underlying deno command exits with a non-zero exit code, causing the workflow step to correctly report failure - The `commandResult` resource is still written before the throw so output is retrievable via `swamp data get` for debugging - Version bumped to `2026.08.23.1` with upgrades entry, manifest and README updated to document the new behavior ## Test plan - [x] 3 new tests verify `run` and `task` throw on non-zero exit while still persisting the output resource - [x] All 33 existing + new tests pass - [x] `deno check`, `deno lint`, `deno fmt --check` all clean - [x] `deno install --frozen` passes (lockfile unchanged) - [ ] Local end-to-end via `swamp extension source add` to verify upgrade path from `2026.08.22.1` 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(deno-runner): fail step when command exits non-zero
All checks were successful
CI: Extensions / cve/researcher - lockfile up to date (pull_request) Has been skipped
CI: Extensions / software-factory - check (pull_request) Has been skipped
CI: Extensions / software-factory - fmt (pull_request) Has been skipped
CI: Extensions / git - lockfile up to date (pull_request) Has been skipped
CI: Extensions / software-factory - lint (pull_request) Has been skipped
CI: Extensions / software-factory - test (pull_request) Has been skipped
CI: Extensions / software-factory - lockfile up to date (pull_request) Has been skipped
CI: Extensions / container-image - check (pull_request) Has been skipped
CI: Extensions / container-image - fmt (pull_request) Has been skipped
CI: Extensions / container-image - lint (pull_request) Has been skipped
CI: Extensions / container-image - test (pull_request) Has been skipped
CI: Extensions / container-image - lockfile up to date (pull_request) Has been skipped
CI: Extensions / git - check (pull_request) Has been skipped
CI: Extensions / git - fmt (pull_request) Has been skipped
CI: Extensions / git - lint (pull_request) Has been skipped
CI: Extensions / git - test (pull_request) Has been skipped
CI / Actions Audit (pull_request) Successful in 28s
CI: Extensions / deno-runner - lint (pull_request) Successful in 45s
CI: Extensions / deno-runner - check (pull_request) Successful in 56s
CI: Extensions / deno-runner - fmt (pull_request) Successful in 57s
CI: Extensions / deno-runner - lockfile up to date (pull_request) Successful in 56s
CI: Extensions / deno-runner - test (pull_request) Successful in 58s
CI: Extensions / Gate: Extensions (pull_request) Successful in 0s
CI / Dependency Audit (pull_request) Successful in 3m45s
CI / Gate: Audit (pull_request) Successful in 0s
CI: Reviews / Detect Changes (pull_request) Successful in 35s
CI: Reviews / Claude Code Review (pull_request) Has been skipped
CI: Reviews / Adversarial Code Review (pull_request) Has been skipped
CI: Reviews / CI Security Review (pull_request) Has been skipped
CI: Reviews / Gate: Reviews (pull_request) Successful in 0s
f465af7810
The run and task methods captured the exit code in the commandResult
resource but never threw, so workflow steps always reported success
even when the underlying deno command failed.

Now both methods check the exit code after writing the resource and
throw if non-zero. The resource is still written first so output is
retrievable via swamp data get for debugging.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
stack72 deleted branch worktree-velvety-petting-floyd 2026-08-23 20:50:31 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
swamp-club/swamp-extensions!219
No description provided.