fix(vercel): conditionally import listAll only when lookup method is generated #168

Merged

stack72 merged 1 commit from fix/vercel-unused-listall-import into main 2026-08-03 13:42:39 +00:00

Conversation 2 Commits 1 Files changed 9 +36 -25

stack72 commented 2026-08-03 13:29:31 +00:00

Owner

Copy link

Summary

• Fixes the unconditional listAll import in codegen/vercel/extensionModelGenerator.ts that caused deno lint no-unused-vars errors in 4 models lacking a lookup method
• listAll is now only included in helperImports when resource.listPath || resource.paginationStyle !== "none" — the same guard used for lookup method generation
• Regenerated all 28 Vercel models; only the 4 affected models changed (import removed, version bumped, upgrade stanza added)

Affected models

• access-groups/projects — no lookup method generated
• blob-storage/blob — no list endpoint exists
• edge-config/token — no lookup method generated
• teams/request — no lookup method generated

Verification

• Second generation run produced 0 diffs (idempotency confirmed)
• deno lint, deno check, deno fmt --check all pass on affected directories
• CalVer bumped exactly the 4 affected services — no extras

Closes #1515

🤖 Generated with Claude Code

## Summary - Fixes the unconditional `listAll` import in `codegen/vercel/extensionModelGenerator.ts` that caused `deno lint` `no-unused-vars` errors in 4 models lacking a lookup method - `listAll` is now only included in `helperImports` when `resource.listPath || resource.paginationStyle !== "none"` — the same guard used for lookup method generation - Regenerated all 28 Vercel models; only the 4 affected models changed (import removed, version bumped, upgrade stanza added) ## Affected models - `access-groups/projects` — no lookup method generated - `blob-storage/blob` — no list endpoint exists - `edge-config/token` — no lookup method generated - `teams/request` — no lookup method generated ## Verification - Second generation run produced 0 diffs (idempotency confirmed) - `deno lint`, `deno check`, `deno fmt --check` all pass on affected directories - CalVer bumped exactly the 4 affected services — no extras Closes #1515 🤖 Generated with [Claude Code](https://claude.com/claude-code)

stack72 added 1 commit 2026-08-03 13:29:31 +00:00

fix(vercel): conditionally import listAll only when lookup method is generated ... 656e1bc883

The Vercel model generator unconditionally imported listAll for every
model, but 4 models don't generate a lookup method (no list path or no
filterable fields). This caused a deno lint no-unused-vars error that
blocked swamp extension push for access-groups/projects,
blob-storage/blob, edge-config/token, and teams/request.

Now listAll is only included in helperImports when the model will
actually generate a lookup method, matching the existing conditional
pattern for read, tryRead, remove, and update imports.

Closes #1515

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

stack72 commented 2026-08-03 13:39:53 +00:00

Author

Owner

Copy link

Adversarial Review

Critical / High

No critical or high severity findings.

Medium

No medium severity findings.

Low

No low severity findings.

Verdict

PASS — The change correctly gates the listAll import behind the same condition (resource.listPath || resource.paginationStyle !== "none") that guards the lookup method where listAll is the sole consumer. The paginationStyle type is "cursor" | "none" (never undefined), so the !== "none" check is safe. The four possible combinations of listPath (string | null) × paginationStyle ("cursor" | "none") all produce consistent import-vs-usage behavior. Clean, minimal fix.

## Adversarial Review ### Critical / High No critical or high severity findings. ### Medium No medium severity findings. ### Low No low severity findings. ### Verdict **PASS** — The change correctly gates the `listAll` import behind the same condition (`resource.listPath || resource.paginationStyle !== "none"`) that guards the lookup method where `listAll` is the sole consumer. The `paginationStyle` type is `"cursor" | "none"` (never undefined), so the `!== "none"` check is safe. The four possible combinations of `listPath` (string | null) × `paginationStyle` ("cursor" | "none") all produce consistent import-vs-usage behavior. Clean, minimal fix.

stack72 commented 2026-08-03 13:40:41 +00:00

Author

Owner

Copy link

Code Review

Blocking Issues

None.

Summary

This PR fixes a codegen bug where listAll was unconditionally imported even
for resources that never use it. The fix aligns the import guard on line 58 of
extensionModelGenerator.ts with the identical guard on line 347 that controls
whether the lookup method (the sole consumer of listAll) is emitted.

Before this fix, resources with no listPath and paginationStyle of "none"
would receive an unused listAll import in their generated file, causing a lint
error. Now listAll is only added to the import when the lookup method will
actually be generated.

The model file changes are legitimate codegen regeneration outputs: projects.ts,
blob.ts, token.ts, and request.ts each had the unused listAll import removed,
received a version bump, and got a matching upgrade entry. CLAUDE.md compliance
is satisfied because the model file changes accompany a codegen/ change.

Suggestions

1. Extract the shared condition to a named constant. The boolean expression
   controlling whether listAll is imported (line 58) is identical to the one
   controlling whether the lookup method is emitted (line 347). Hoisting it to a
   named local variable such as "hasListMethod" before both uses would prevent
   future divergence if the condition ever needs to change.

## Code Review ### Blocking Issues None. ### Summary This PR fixes a codegen bug where listAll was unconditionally imported even for resources that never use it. The fix aligns the import guard on line 58 of extensionModelGenerator.ts with the identical guard on line 347 that controls whether the lookup method (the sole consumer of listAll) is emitted. Before this fix, resources with no listPath and paginationStyle of "none" would receive an unused listAll import in their generated file, causing a lint error. Now listAll is only added to the import when the lookup method will actually be generated. The model file changes are legitimate codegen regeneration outputs: projects.ts, blob.ts, token.ts, and request.ts each had the unused listAll import removed, received a version bump, and got a matching upgrade entry. CLAUDE.md compliance is satisfied because the model file changes accompany a codegen/ change. ### Suggestions 1. Extract the shared condition to a named constant. The boolean expression controlling whether listAll is imported (line 58) is identical to the one controlling whether the lookup method is emitted (line 347). Hoisting it to a named local variable such as "hasListMethod" before both uses would prevent future divergence if the condition ever needs to change.

stack72 merged commit 6659ce0160 into main 2026-08-03 13:42:39 +00:00

stack72 referenced this pull request from a commit 2026-08-03 13:42:39 +00:00

fix(vercel): conditionally import listAll only when lookup method is generated (#168)

stack72 deleted branch fix/vercel-unused-listall-import 2026-08-03 13:42:40 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

swamp-club/swamp-extensions!168

No description provided.